Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine cupsatial demo to make it more clear for customers #187

Merged
merged 66 commits into from
Jul 19, 2022
Merged

refine cupsatial demo to make it more clear for customers #187

merged 66 commits into from
Jul 19, 2022

Conversation

nvliyuan
Copy link
Collaborator

@nvliyuan nvliyuan commented Jun 24, 2022 •
edited
Loading

refine cupsatial demo to make it more clear for customers

  • update cuda pub key to avoid GPG error in databricks docker file
  • update performance target to a specific dataset
  • add more comments about how to build/run
  • add cpu version notebook base on Apache Sedona

Signed-off-by: liyuan [email protected]

@nvliyuan nvliyuan changed the title refine cupsatial demo to make it more clear for customers [WIP]refine cupsatial demo to make it more clear for customers Jun 24, 2022
nvliyuan added 10 commits July 4, 2022 14:05
@nvliyuan
address review comments
85b9491 
Signed-off-by: liyuan <[email protected]>
@nvliyuan
address review comments
b7cfe33 
Signed-off-by: liyuan <[email protected]>
@nvliyuan
fit img size
81093a4 
Signed-off-by: liyuan <[email protected]>
@nvliyuan
fit img size
eeb3206 
Signed-off-by: liyuan <[email protected]>
@nvliyuan
fit some types
d4c8071 
Signed-off-by: liyuan <[email protected]>
@nvliyuan
try resize img
cfaa7c5 
Signed-off-by: liyuan <[email protected]>
@nvliyuan
try resize img
5a11e74 
Signed-off-by: liyuan <[email protected]>
@nvliyuan
try resize img
b4a25c9 
Signed-off-by: liyuan <[email protected]>
@nvliyuan
try resize img
744db7a 
Signed-off-by: liyuan <[email protected]>
@nvliyuan
try resize img
118b60b 
Signed-off-by: liyuan <[email protected]>
@nvliyuan nvliyuan changed the title [WIP]refine cupsatial demo to make it more clear for customers refine cupsatial demo to make it more clear for customers Jul 4, 2022
@nvliyuan nvliyuan marked this pull request as ready for review July 4, 2022 06:28
sameerz
sameerz reviewed Jul 4, 2022
View reviewed changes
Copy link
Collaborator

@sameerz sameerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command docker build -f Dockerfile . -t build-spark-cuspatial on line 44 is failing. I get the following:

ERROR conda.cli.main_run:execute(49): `conda run /bin/bash -c conda install -c rapidsai-nightly -c nvidia -c conda-forge -c defaults libcuspatial=22.06 python=3.8 -y` failed. (See above for error)

Is this failing because we are mixing 22.06 and 22.08-SNAPSHOT?

Detailed error in https://gist.github.com/sameerz/544c046bf0b13683288df846d5d5673f

@nvliyuan
Copy link
Collaborator Author

nvliyuan commented Jul 5, 2022

Detailed error in https://gist.github.com/sameerz/544c046bf0b13683288df846d5d5673f

yes, I can reproduce it by running docker build without cache, update the docker file

@sameerz
Copy link
Collaborator

sameerz commented Jul 5, 2022

Detailed error in https://gist.github.com/sameerz/544c046bf0b13683288df846d5d5673f

yes, I can reproduce it by running docker build without cache, update the docker file

I can build the docker file now and was able to build the spark-cuspatial-22.08.0-SNAPSHOT.jar.

Do we want to update lines 66-69 in README.md to refer to 22.06 and 22.08-SNAPSHOT instead of 22.04 and 22.06-SNAPSHOT?

@nvliyuan
Copy link
Collaborator Author

nvliyuan commented Jul 5, 2022

Do we want to update lines 66-69 in README.md to refer to 22.06 and 22.08-SNAPSHOT instead of 22.04 and 22.06-SNAPSHOT?

updated, thanks

@nvliyuan
add cpu notebook
bac294e 
Signed-off-by: liyuan <[email protected]>
@nvliyuan
Copy link
Collaborator Author

nvliyuan commented Jul 8, 2022

Add CPU notebook run on databricks

@nvliyuan nvliyuan requested a review from sameerz July 8, 2022 15:48
@nvliyuan nvliyuan requested a review from NvTimLiu July 11, 2022 02:37
nvliyuan and others added 24 commits July 15, 2022 13:45
@nvliyuan @viadea
Update examples/UDF-Examples/Spark-cuSpatial/README.md
07e9f0f 
Co-authored-by: Hao Zhu <[email protected]>
@nvliyuan @viadea
Update examples/UDF-Examples/Spark-cuSpatial/README.md
e21e5bb 
Co-authored-by: Hao Zhu <[email protected]>
@nvliyuan @viadea
Update examples/UDF-Examples/Spark-cuSpatial/README.md
f38ee0d 
Co-authored-by: Hao Zhu <[email protected]>
@nvliyuan @viadea
Update examples/UDF-Examples/Spark-cuSpatial/README.md
c4e97a3 
Co-authored-by: Hao Zhu <[email protected]>
@nvliyuan @viadea
Update examples/UDF-Examples/Spark-cuSpatial/README.md
4bd4ad5 
Co-authored-by: Hao Zhu <[email protected]>
@nvliyuan @viadea
Update examples/UDF-Examples/Spark-cuSpatial/README.md
b8f9743 
Co-authored-by: Hao Zhu <[email protected]>
@nvliyuan @viadea
Update examples/UDF-Examples/Spark-cuSpatial/README.md
2ce7cca 
Co-authored-by: Hao Zhu <[email protected]>
@nvliyuan @viadea
Update examples/UDF-Examples/Spark-cuSpatial/README.md
36ca185 
Co-authored-by: Hao Zhu <[email protected]>
@nvliyuan @viadea
Update examples/UDF-Examples/Spark-cuSpatial/README.md
91a143b 
Co-authored-by: Hao Zhu <[email protected]>
@nvliyuan @viadea
Update examples/UDF-Examples/Spark-cuSpatial/README.md
8304d9a 
Co-authored-by: Hao Zhu <[email protected]>
@nvliyuan @viadea
Update examples/UDF-Examples/Spark-cuSpatial/README.md
e741f74 
Co-authored-by: Hao Zhu <[email protected]>
@nvliyuan @viadea
Update examples/UDF-Examples/Spark-cuSpatial/README.md
3135606 
Co-authored-by: Hao Zhu <[email protected]>
@nvliyuan @viadea
Update examples/UDF-Examples/Spark-cuSpatial/README.md
cf2715e 
Co-authored-by: Hao Zhu <[email protected]>
@nvliyuan @viadea
Update examples/UDF-Examples/Spark-cuSpatial/README.md
3a04e4e 
Co-authored-by: Hao Zhu <[email protected]>
@nvliyuan @viadea
Update examples/UDF-Examples/Spark-cuSpatial/README.md
a0777d9 
Co-authored-by: Hao Zhu <[email protected]>
@nvliyuan @viadea
Update examples/UDF-Examples/Spark-cuSpatial/README.md
35e6706 
Co-authored-by: Hao Zhu <[email protected]>
@nvliyuan @viadea
Update examples/UDF-Examples/Spark-cuSpatial/README.md
c2ce8d9 
Co-authored-by: Hao Zhu <[email protected]>
@nvliyuan @viadea
Update examples/UDF-Examples/Spark-cuSpatial/README.md
803c6f5 
Co-authored-by: Hao Zhu <[email protected]>
@nvliyuan
try to workarround broken link error
b190d56 
Signed-off-by: liyuan <[email protected]>
@nvliyuan
try to workarround broken link error
935d3b9 
Signed-off-by: liyuan <[email protected]>
@nvliyuan
try to workarround broken link error
3e6f0ed 
Signed-off-by: liyuan <[email protected]>
@nvliyuan
try to workarround broken link error
fa52056 
Signed-off-by: liyuan <[email protected]>
@nvliyuan
try to workarround broken link error
6f1628b 
Signed-off-by: liyuan <[email protected]>
@nvliyuan
try to workarround broken link error
d9b4d59 
Signed-off-by: liyuan <[email protected]>
@viadea viadea self-requested a review July 18, 2022 17:16
viadea
viadea previously approved these changes Jul 18, 2022
View reviewed changes
@nvliyuan nvliyuan merged commit 8c4809c into NVIDIA:branch-22.08 Jul 19, 2022
@nvliyuan nvliyuan deleted the cuspatial-refine branch December 20, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firestarman firestarman firestarman left review comments

@NvTimLiu NvTimLiu NvTimLiu left review comments

@viadea viadea viadea left review comments

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008

@sameerz sameerz Awaiting requested review from sameerz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nvliyuan @sameerz @viadea @firestarman @NvTimLiu